New York City’s new pied-à-terre tax is prompting financial advisors to help wealthy clients reassess their options, from residency status to estate plans.